Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take care about commonInitialisms in ToGo #579

Merged
merged 4 commits into from
Mar 6, 2019
Merged

Take care about commonInitialisms in ToGo #579

merged 4 commits into from
Mar 6, 2019

Conversation

vvakame
Copy link
Collaborator

@vvakame vvakame commented Mar 5, 2019

in v0.8.0, RelatedURLs is convert to RelatedUrls, and ImageIDs be ImageIds.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

Copy link
Collaborator

@vektah vektah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reproducing logic in lintName. ToCamel can probably be deleted if we update ToGo and ToGoPrivate.

codegen/templates/templates.go Outdated Show resolved Hide resolved
@vvakame vvakame changed the title Take care about commonInitialisms in ToCamel Take care about commonInitialisms in ToGo Mar 6, 2019
Copy link
Collaborator

@vektah vektah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 This looks great

@vektah vektah merged commit 737a59a into master Mar 6, 2019
@vektah vektah deleted the fix-camelcase branch March 6, 2019 11:37
@vektah vektah mentioned this pull request Mar 6, 2019
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
Take care about commonInitialisms in ToGo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants